[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562504

--- Comment #13 from Lisandro Dalcin <dalcinl at gmail.com> 2010-02-16 12:20:53 EST ---
Hi, I'm the author of mpi4py and a Fedora user since the project started. I
would like to make some comments on the way mpi4py is being packaged and
propose some cleanups in the spec file.

First of all, I'm preparing a bug-fix release being tracked in
https://mpi4py.googlecode.com/svn/branches/release-1.2 . Up to now, the
accumulated fixes are all related to the custom distutils-based buildsystem and
the removal of a hidden file in the documentation (I actually noticed this
after looking at mpi4py.spec). Additionally, I've disabled some failing tests
for Open MPI (after discussing about the failure in the Open MPI devel ML).
Hopefully, I'll make a bug-fix release soon, and we will have time to get
mpi4py-1.2.1 in Fedora 13.

1) Please DO NOT REMOVE all empty pyx/pxd files!!. In particular, the files
'__init__.pyx' and '__init__.pxd' located at 'src/include/mpi4py' DO ARE
REQUIRED for Cython support (i.e. for accessing mpi4py internals at the C level
when using Cython's "cimport" statement). If these empty files cause any issue,
they could be added a single comment line, let say "# placeholder" or something
like that.

2) I would remove the whole 'docs/source/slides' directory. BTW, the contents
of 'docs/source/usrman' are the reST sources from which the 'docs/usrman/*'
HTML documentation (and 'docs/mpi4py.pdf') are generated (using Sphinx and
Latex)... So perhaps the whole directory 'docs/source' could be removed, though
the  almost-plain-text reST sources at 'docs/source/usrman' could be handy.

3) mpi4py's custom, distutils-based buildsystem (conf/mpidistutils.py) already
handles MPI compiler wrappers mpicc/mpicxx (as long as they can be found in
$PATH), so there is not need to "export CC=mpicc CXX=mpicxx".


4) mpi4py DO SUPPORT Python 3. Moreover, the testsuite should also run and all
tests pass. Of course, about half the tests will not run because of missing
numpy, but the other half will use Python's builtin "array.array" instances.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.