[Bug 565902] Review Request: csync - a bidirectional file synchronizer for roaming home directories

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565902

--- Comment #3 from Kevin Kofler <kevin at tigcc.ticalc.org> 2010-02-16 14:50:09 EST ---
There are still a few suseisms there. ;-)

* "# norootforbuild" is redundant and not used by anything around here, our
build system (Koji) never builds as root. I'd suggest removing that magic
comment (though it is not required as we don't have guidelines for comments ;-)
).
* While you fixed the main package's License tag, the License tags for the
subpackages are still bad (not compliant to Fedora guidelines). This is a MUST
fix.
* The cmake invocation should use the %cmake macro. This one also definitely
needs to be fixed.
* While %__make, %__rm, %{__mkdir} and the like are acceptable, we generally
just write make, rm, mkdir etc., those macros which expand to full paths are
not really necessary. (But this is not a must.)
* We don't systematically split out lib* subpackages, but in this case I guess
it makes sense. The most common naming convention for those subpackages in
Fedora is of the csync-libs form, but libcsync is OK as a name in this case.
(So IMHO that item is fine here, this was just informative.)

(Note: this is not a full review, just the stuff I noticed at first glance.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.