[Bug 494695] Review Request: qutim - Multiplatform Instant Messenger on Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494695

Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org

--- Comment #41 from Christoph Wickert <cwickert at fedoraproject.org> 2010-02-16 20:13:35 EST ---
The spec could be more readable if it was formatted properly. Please use line
breaks at 80 charakters, especially in the descriptions. Otherwise they are
hard to read on a terminal or in the PackageKit UI.

The name of the tag is "URL", not "Url".

The group of the -devel package should be Development/Libraries instead of
Applications/Internet. For the other subpackages you can omit the group tag
because it is the same than the one from the base package.

%descriptions should end with a dot. Exclamation marks are even worse than the
missing dots.

There are a lot of linguistic and grammar errors in the English descriptions.

The icon cache scriptlets are outdated, please use the latest version from 
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

Omit --add-category="Network" from desktop-file-install because this is already
in the file.

Please preserve timestamps during %install, 
install -p -m 644 icons/%{name}.png ...
...
make install DESTDIR="%{buildroot}" INSTALL="install -p"
see https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

Please use %global instead of %define, see 
https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define
Just a hint, this is commented out currently.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.