[Bug 565764] Review Request: sugar-measure - Measure functionality for Sugar

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 17 05:39:18 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565764

--- Comment #2 from Kedar Sovani <kedars at marvell.com> 2010-02-17 00:39:14 EST ---
(In reply to comment #1)
> Just a few comments, I'm no sponsor anyway:

sure, Thanks!

> 
> - Try running rpmlint -I $(warning/error)
> 
> -> $ rpmlint -I non-executable-script
> non-executable-script:
> This text file contains a shebang or is located in a path dedicated for
> executables, but lacks the executable bits and cannot thus be executed.  If
> the file is meant to be an executable script, add the executable bits,
> otherwise remove the shebang or move the file elsewhere.
> 
> 

Yes, I meant that I believe both the type of errors above are false-positives
in this case. Is there any spec-file workaround for those?

> - BuildRequires should be python-devel and not just python. BuildRequires
> python will be added automatic then.    

Hmm... Actually it doesn't really need python-devel in this case, just python
is sufficient. Here is a koji scratch build. 
http://koji.fedoraproject.org/koji/taskinfo?taskID=1992656

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list