[Bug 565603] Review Request: kitutuki - Shell script language

bugzilla at redhat.com bugzilla at redhat.com
Wed Feb 17 08:56:29 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565603

Matthew Kent <mkent at magoazul.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #5 from Matthew Kent <mkent at magoazul.com> 2010-02-17 03:56:26 EST ---
(In reply to comment #3)
> Thank you for reviewing this.
> 
> (In reply to comment #2)
> > Quick initial notes:
> > - License - the included file says it's GPLv2
> - (On Fedora) just putting GPLv2 license text into the tarball
>   does not mean that it is under GPLv2, rather it is under GPL+
>  
> https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F
> 

Thanks for this - wasn't aware. 

Ah and I see GPL in the README.ja.txt now that I look closer.

> > - rpmlint complains of a missing BuildRoot tag
> - I explicitly removed this because BuildRoot is no longer used.
> 

Wasn't aware - thanks.

----

Package is well organized, compiles and functions. I don't see any blockers.

--------------------------------------------------------
  This package (kitutuki) is approved by mkent
--------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list