[Bug 518647] Review Request: django-robots - django extension to manage correctly robots.txt

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518647

Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name

--- Comment #9 from Till Maas <opensource at till.name> 2010-02-17 05:13:49 EST ---
(In reply to comment #8)
> Sadly, I'm unable to give you an official review. If you like, I'd give you
> some inofficial comments

> * %define version vs. Version: ?

The "%define version" needs to go away.

> * License seems to be a kind of propriary license. Listed in SPEC is BSD,
> LICENSE.txt 

I did not look at the LICENSE.txt, but there are a lot of variations of the BSD
license, maybe it matches one of these:
https://fedoraproject.org/wiki/Licensing/BSD

> * find_lang is unused in favor of own script. (ok / not ok ?)

This seems to be ok, because find_lang only searches in /usr/share/locale. But
on the other hand, maybe the files should be installed in /usr/share/locale
instead.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.