[Bug 554260] Review Request: ibus-table-xingma - The structure tables for IBus-Table

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=554260

Naveen Kumar <nkumar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nkumar at redhat.com

--- Comment #2 from Naveen Kumar <nkumar at redhat.com> 2010-02-17 07:11:57 EST ---
Here's an unofficial review, using the checklist from:
http://fedoraproject.org/wiki/User:Tibbs/Review_Template

- source files do not match upstream: Could not retrieve files from upstream,
specified in specfile, to do checksum
Other checksum output from srpm sources were:
163844d682a24c334752749e2fbb445f9b403a2c56a66f261b3d4c4ca292c478 
:ibus-table-xingma-1.2.0.20100111.tar.gz
74ef342db7795af6552da53a0f57927f6f5a47b9243df6ba77f4edad0b43eb0c 
:ibus-table-xingma.spec


+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible.
     license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
- Koji Build failed: http://koji.fedoraproject.org/koji/taskinfo?taskID=1992777
- rpmlint is not silent. (rpmlint version 0.91)

rpmlint OUTPUT on src rpm:
ibus-table-xingma.src: E: description-line-too-long The structure tables for
IBus Table, namely Wu, Yong, ZhuYin, ZhuYin Big, ZiRanMa.
1 packages and 0 specfiles checked; 1 errors, 0 warnings.

rpmlint OUTPUT on rpm:
ibus-table-xingma.noarch: E: description-line-too-long The structure tables for
IBus Table, namely Wu, Yong, ZhuYin, ZhuYin Big, ZiRanMa.
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-stroke5
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-wubi
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-xinhua
ibus-table-xingma.noarch: W: obsolete-not-provided ibus-table-zhengma
1 packages and 0 specfiles checked; 1 errors, 4 warnings.


* final provides and requires output:
   rpm -qp --provides output:  
ibus-table-xingma = 1.2.0.20100111-1.fc12

   rpm -qp --requires output: 
/bin/sh  
ibus >= 1.2
ibus >= 1.2
ibus-table >= 1.2.0.20100111
ibus-table >= 1.2.0.20100111
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rpmlib(PayloadIsXz) <= 5.2-1


+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ scriptlets sane
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.