[Bug 540996] Review Request: rubygem-ffi - Foreign Function Interface package for Ruby

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=540996

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-17 11:58:32 EST ---
Well,

- "Requires: libffi >= 3.0.5" is not needed because libffi in currently
  supported Fedora branch (i.e. F-11/12/13/14) all satisfy this version,
  and libffi.so.X dependency is automatically detected.
  (see the last sentence of below:
   https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires )

- %dir %{geminstdir} is also needed
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes

- The first %defattr(-,root,root,-) is enough. The second %defattr
  is redundant.

Please fix these when importing this package into Fedora CVS.
---------------------------------------------------------------
    This package (rubygem-ffi) is APPROVED by mtasaka
---------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.