[Bug 565858] Review Request: rubygem-thin - A thin and fast web server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565858

--- Comment #13 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-18 12:11:05 EST ---
For -4:

* %exclude
  - Well, perhaps you used %exclude to group files by license,
    however %exclude completely removes listed files from
    the binary rpm, even if %exclude'd files are listed later
    (in the same subpackage %files list, %exclude'd files
     can appear in other subpackages).

    You'll see that %exclude'd files are actually not in
    rebuilt binary rpm.

* Directory ownership issue
  - The directory %{geminstdir}/bin itself is not owned by
    any packages.
    https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Common_Mistakes

* License tag
  - In this case we should use "(GPLv2 or Ruby) and MIT and BSD" (i.e.
    need parentheses)

* ppc64
  - For rake spec2 failing issue, I think
-----------------------------------------------------------------------
%check
%ifarch ppc64
# Disable tests
exit 0
%endif
pushd .%{geminstdir}
....
....
-----------------------------------------------------------------------
    is preferable.

* Miscs
------------------------------------------------------------------------
rubygem-thin.src: E: description-line-too-long C Thin is a Ruby web server
.....
------------------------------------------------------------------------
  - It is suggested that one line should not contain more than
    79 characters.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.