[Bug 491497] Review Request: dmapd - A server that provides DAAP and DPAP shares

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491497

Christian Krause <chkr at plauener.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #27 from Christian Krause <chkr at plauener.de> 2010-02-18 17:00:38 EST ---
Thanks for the new package. 

Please don't forget to upload the 0.0.23 tarball to
http://www.flyn.org/projects/dmapd/ too.

All show-stoppers were solved.

-> APPROVED


Here are a couple of items I still don't like but which don't block the review:

- although the spec file is technically correct it would be better for further
"maintainability" (also by other maintainers), if the standard order of the
sections would by 100% followed

- the same applies for squeezing the scriptlets into a single line (opposite to
Fedora's templates)

- all debug, warning and error messages should be written into a log file
rather to stdout/stderr

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.