[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 18 23:20:59 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508750

--- Comment #15 from David A. Wheeler <dwheeler at dwheeler.com> 2010-02-18 18:20:56 EST ---
Sigh - there's a small problem.  This new spec's Release number doesn't match
the Changelog. It says:
 Release:        1%{?dist}
but the Changelog says:
 * Thu Feb 18 2010 Rahul Sundaram <sundaram at fedoraproject.org> - 0.11.2-2
(note the -2 at the end.)

I doubt upstream will update their man page.  It's this *Fedora* package that
is renaming "trash" into "trash-put".  Since the rename is a Fedora-local
change, it'd be nice if the installed Fedora docs matched what's installed (at
least in the Name, Synopsis, and Examples sections for trash-put).  Since man
pages aren't REQUIRED, I guess I can't REQUIRE that change, but I think I
should note that.

Note to others reading this review request: This spec depends on more-modern
rpm, so this spec would need to be changed for older RPM-based systems like
EPEL 5 or less:
* %install does not start with "rm -rf %{buildroot}".
  This violates the guidelines of:
   http://fedoraproject.org/wiki/Packaging:ReviewGuidelines
* No "BuildRoot" value set.  This violates the *old* review guidelines.
I view these as both okay, since the Fedora guidelines now specifically permit
this:
   http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
I thought it'd be important to document that.

So please fix the release, consider the man page change, and repost.  You're
almost there!!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list