[Bug 561448] Review Request: jffi - Java Foreign Function Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561448

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?

--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-19 00:44:15 EST ---
For 0.6.5-1:

* Compilation issue
  A First of all, now build fails:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1996972
    This is because -Werror.

  B Even after -Werror is removed, build fails on ppc64:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1997040
    The failing command is:
------------------------------------------------------------------------
     [exec] cc -m32  -o
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/libjffi-0.6.so  -shared
-mimpure-text -static-libgcc -Wl,-soname,libjffi-0.6.so -Wl,-O1 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Array.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Closure.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Exception.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/FastIntInvoke.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/FastLongInvoke.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Foreign.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Function.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Internals.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Invoke.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/LastError.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Library.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Memory.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/MemoryIO.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Struct.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/Type.o 
/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/jffi/deprecated.o -lffi  
     [exec] /usr/bin/ld: crti.o: No such file: No such file or directory
     [exec] collect2: ld returned 1 exit status
     [exec] make: ***
[/builddir/build/BUILD/wmeissner-jffi-bbb81f1/build/jni/libjffi-0.6.so] Error 1
-----------------------------------------------------------------------
    Well, -m32 is wrong for ppc64. This is because {jni/libtest}/GNUmakefile
    does not check if the arch is ppc64 or not.... however
    this check is anyway not needed anyway.

* Test
  - Forgot to mention this, however please check if some test programs
    are available or not (as this package contains test/ directory)

* Empty debuginfo
-----------------------------------------------------------------------
jffi-debuginfo.i686: E: debuginfo-without-sources
-----------------------------------------------------------------------
  - Well, I don't know how Java packages treat this by default,
    however generally to create debuginfo rpm corretly, libjffi-0.6.so
    should not be stripped in build process itself and should
    be handled by find-debuginfo.sh and so on.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.