[Bug 558228] Review Request: perl-Tk-DirSelect - Cross-platform directory selection widget

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=558228

--- Comment #3 from Emmanuel Seyman <emmanuel.seyman at club-internet.fr> 2010-02-19 00:52:24 EST ---
We're almost there.

David, you need to add perl(Test::More) to the BuildRequires of your spec file
(and in the future, please test your package with mock or koji before
submitting a .src.rpm).

>From the spec file:
>
> sed -i 's/\r//' Changes
> sed -i 's/\r//' README

Nitpick.
I'ld write this: sed -i 's/\r//' Changes README

and this really belongs in the prep section of the spec file more than the
install one.

Please consider adding "%{?perl_default_filter}" to your spec before the
%description block.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.