[Bug 226108] Merge Review: lsof

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226108

Karel Zak <kzak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |MODIFIED

--- Comment #9 from Karel Zak <kzak at redhat.com> 2010-02-19 08:12:10 EST ---
Sorry for delay, I forgot...

(In reply to comment #7)
> * `upstream2downstream.sh' -- could have license statement

 well, "Public Domain" :-) -- note that the file is not distributed in srpm.
It's in our CVS only.

> * %define lsofrh lsof_4.81-rh -- incorporate %{version} here

 Fixed.

> Patching starts from "Patch0" :)

 Fixed.

> * Don't mix macro and variable style 
>   - $RPM_OPT_FLAGS -> %{optflags}
>   - ${RPM_BUILD_ROOT} -> %{buildroot}

 Ah.. so pedentic ;-) Not fixed. I don't think it's more readable.

> * %defattr(644,root,root,755) -> %defattr(-,root,root,-) it's the same and the
> later preferred

 Fixed.

> * %attr(0755,root,root) %{_sbindir}/lsof
> `-------^^^^^---(not necessary)

 Fixed.

All changes are avaialable in lsof-4.83-2.fc14, Thanks  for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.