[Bug 564466] Review Request: ubuntutitle-fonts - decorative font of Ubuntu logo

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564466

Naveen Kumar <nkumar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nkumar at redhat.com

--- Comment #1 from Naveen Kumar <nkumar at redhat.com> 2010-02-19 10:27:24 EST ---
Here's an unofficial review, using the checklist as reference from:
http://fedoraproject.org/wiki/User:Tibbs/Review_Template


+ source files match upstream:  
18b223615ba2e3444b87360bba80f0cefdcda51b8cf50354e3d3a052b791370c 
:ubuntu-title-002.000.tar.gz from source and upstream.

+package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.

? (+/-) Copying.txt specifies "OFL 1.1 and GPL 2 with exceptions" where as
specfile mentions "OFL or GPLv2 with exceptions". 
+ licenses are open source-compatible: license text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
- Koji scratch build failed:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1999283
+ package installs properly.
+ rpmlint is silent. (rpmlint version 0.91)
+ final provides and requires are sane:
    rpm -qp --provides output:
config(ubuntutitle-fonts) = 002.000-1.fc12
font(:lang=fj)  
font(:lang=ho)  
font(:lang=ia)  
font(:lang=ie)  
font(:lang=io)  
font(:lang=kj)  
font(:lang=kwm)  
font(:lang=ms)  
font(:lang=ng)  
font(:lang=nr)  
font(:lang=om)  
font(:lang=rn)  
font(:lang=rw)  
font(:lang=sn)  
font(:lang=so)  
font(:lang=ss)  
font(:lang=st)  
font(:lang=sw)  
font(:lang=ts)  
font(:lang=uz)  
font(:lang=xh)  
font(:lang=za)  
font(:lang=zu)  
font(ubuntu-title)  
ubuntutitle-fonts = 002.000-1.fc12

   rpm -qp --requires output: 
/bin/sh  
/bin/sh  
config(ubuntutitle-fonts) = 002.000-1.fc12
fontpackages-filesystem  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

+ no shared libraries are added to the regular linker search paths.
 + owns the directories it creates.
+ doesn't own any directories it shouldn't.
* no %files section
+ file permissions are appropriate.
+ scriptlets sane
+ content (font)
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ no desktop files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.