[Bug 565958] Review Request: SynapticsConfig - tool for configuring touchpads
bugzilla at redhat.com
bugzilla at redhat.com
Fri Feb 19 19:42:48 UTC 2010
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=565958
--- Comment #7 from timlank <timlank at timlank.com> 2010-02-19 14:42:42 EST ---
just a little note about the %files section...
the %defattr should be: %defattr(-,root,root,-)
Please reference:
http://fedoraproject.org/wiki/PackagingGuidelines#File_Permissions
Also, please change my item #6 in my first post to be "rm -rf $RPM_BUILD_ROOT"
-for the %install - either that or use the macro style suggested - but of
course then you will need to change the other occurences of $RPM_BUILD_ROOT in
the SPEC. They're looking for consistency - it doesn't matter which style,
just that there is consistency.
Please reference: http://fedoraproject.org/wiki/PackagingGuidelines#Macros
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list