[Bug 562504] Review Request: mpi4py - Python bindings of the Message Passing Interface (MPI)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562504

--- Comment #16 from Jussi Lehtola <jussi.lehtola at iki.fi> 2010-02-20 01:42:55 EST ---
Sorry, I've been busy for some time. Here's the review:

rpmlint output:
mpi4py-mpich2.x86_64: W: no-documentation
mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/dl.so 0775
mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/MPE.so 0775
mpi4py-mpich2.x86_64: E: zero-length
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/include/mpi4py/__init__.pxd
mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.MPI_api.h
mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.MPI.h
mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/MPI.so 0775
mpi4py-mpich2.x86_64: E: zero-length
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/include/mpi4py/__init__.pyx
mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.h
mpi4py-openmpi.x86_64: W: no-documentation
mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.MPI_api.h
mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.h
mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/MPI.so 0775
mpi4py-openmpi.x86_64: E: zero-length
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/include/mpi4py/__init__.pyx
mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/MPE.so 0775
mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/dl.so 0775
mpi4py-openmpi.x86_64: E: zero-length
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/include/mpi4py/__init__.pxd
mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python2.6/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.MPI.h
python3-mpi4py-mpich2.x86_64: W: no-documentation
python3-mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/dl.so 0775
python3-mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.h
python3-mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/MPE.so 0775
python3-mpi4py-mpich2.x86_64: E: zero-length
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/include/mpi4py/__init__.pyx
python3-mpi4py-mpich2.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/MPI.so 0775
python3-mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.MPI.h
python3-mpi4py-mpich2.x86_64: E: zero-length
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/include/mpi4py/__init__.pxd
python3-mpi4py-mpich2.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/mpich2/mpi4py/include/mpi4py/mpi4py.MPI_api.h
python3-mpi4py-openmpi.x86_64: W: no-documentation
python3-mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/dl.so 0775
python3-mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/MPE.so 0775
python3-mpi4py-openmpi.x86_64: E: non-standard-executable-perm
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/MPI.so 0775
python3-mpi4py-openmpi.x86_64: E: zero-length
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/include/mpi4py/__init__.pyx
python3-mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.MPI_api.h
python3-mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.MPI.h
python3-mpi4py-openmpi.x86_64: E: zero-length
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/include/mpi4py/__init__.pxd
python3-mpi4py-openmpi.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/python3.1/site-packages/openmpi/mpi4py/include/mpi4py/mpi4py.h
8 packages and 0 specfiles checked; 20 errors, 16 warnings.

MUST: Fix the permissions, they should be 755 for libraries.


***

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. OK
- I think the 0%{?rhel}>6 should be 0%{?rhel}>5, since RHEL 6 hasn't even been
published yet. The python3 draft isn't really consistent in this.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- Source code doesn't contain license headers.
- Attached LICENSE.txt does, however, specify the license to be BSD.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK

MUST: Permissions on files must be set properly. NEEDSWORK
- Fix the lib perms with chmod at the end of %install.

MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application.  ~OK
- I suggest adding PKG-INFO and THANKS.txt to -common.

MUST: Header files must be in a -devel package. OK
- This doesn't really apply here.

MUST: Static libraries must be in a -static package. N/A
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'.
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.