[Bug 562351] Review Request: perl-Data-Dumper-Concise - A convenient way to reproduce a set of Dumper options

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562351

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-02-20 03:43:29 EST ---
Looks good.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001121

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream:
8623d8cca85c0585d629425075fb5df9  Data-Dumper-Concise-1.100.tar.gz

Final provides are sane:
perl(Data::Dumper::Concise) = 1.100
perl(Data::Dumper::Concise::Sugar)  
perl(Devel::Dwarn)  
perl-Data-Dumper-Concise = 1.100-1.fc14

Final requires are sane:
perl(:MODULE_COMPAT_5.10.1)  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(VersionedDependencies) <= 3.0.3-1
perl >= 0:5.006
perl(Data::Dumper)  
perl(Data::Dumper::Concise)  
perl(Data::Dumper::Concise::Sugar)  
perl(Exporter)  

rpmlint picks up a valid typo in %description (hass -> has)
perl-Data-Dumper-Concise.noarch: W: spelling-error %description -l en_US hass
-> sash, has, ass
perl-Data-Dumper-Concise.noarch: W: spelling-error %description -l en_US ve ->
be, v, e

Fix the typo and you're good to go. APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.