[Bug 562374] Review Request: perl-MooseX-Role-WithOverloading - Roles which support overloading

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=562374

Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Iain Arnell <iarnell at gmail.com> 2010-02-20 07:14:27 EST ---
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2001212

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarball matches upstream
a1084e98f8deaef75cdfc3fecc59a149  MooseX-Role-WithOverloading-0.05.tar.gz

Final provides are sane
perl(MooseX::Role::WithOverloading) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToClass)
= 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToInstance)
= 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::Composite::ToRole)
= 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::FixOverloadedRefs)
= 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToClass) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToInstance) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Application::ToRole) = 0.05
perl(MooseX::Role::WithOverloading::Meta::Role::Composite) = 0.05
perl-MooseX-Role-WithOverloading = 0.05-1.fc14
perl-MooseX-Role-WithOverloading(x86-64) = 0.05-1.fc14

Final requires are sane
perl(:MODULE_COMPAT_5.10.1)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl(aliased)  
perl(Moose)  
perl(Moose::Exporter)  
perl(Moose::Role)  
perl(Moose::Util::MetaRole)  
perl(MooseX::Types::Moose)  
perl(namespace::autoclean)  
perl(namespace::clean)  
perl(overload)  
perl(XSLoader)  

rpmlint only has pointless complaints
perl-MooseX-Role-WithOverloading.src: W: spelling-error %description -l en_US
overloadings -> overloading, overloading s, overloads
perl-MooseX-Role-WithOverloading.x86_64: W: spelling-error %description -l
en_US overloadings -> overloading, overloading s, overloads
perl-MooseX-Role-WithOverloading-debuginfo.x86_64: E: description-line-too-long
C This package provides debug information for package
perl-MooseX-Role-WithOverloading.

You might want to enable the two "release candidate" tests if they pass.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.