[Bug 566171] Review Request: libhid - A userspace USB HID acess library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566171

--- Comment #3 from Manuel F Martinez <manpaz at bashlinux.com> 2010-02-20 14:19:53 EST ---
Thank your for your advise. Here the changes I've made:

1. I removed the "A" article.

2. The GPL Version 3 comes from automake at build time, but looking at the
upstream website http://libhid.alioth.debian.org/, they claim libhid is
released under the terms of the GPLVersion 2, so I've fixed it to GPLv2

3. The upstream says -devel includes static libraries,  but the Package
Gideline says to put static on a -static package, and take this action only if
static is really necessary, so I'm removed static libraries, no I'm removing
"static library" statement from -devel description.

4. I'm removing --force from libtoolize, I just copied the whole command with
parameters as "autogen.sh" does, but now I'm using "make
DESTDIR=$RPM_BUILD_ROOT install" as suggested in the link provided by you.

5. %deffattr(0644,root,root) I left because I was getting trouble with
manpages, but then I create a patch and forgot to remove %deffattr, sorry, my
bad.

6. libusb-devel added to libhid-devel.

I rebuild release 2 on Koji and the build was completed successfully.
http://koji.fedoraproject.org/koji/tasks?state=closed&owner=manpaz

Once again, thank you for your advise.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.