[Bug 563481] Review Request: aduna-commons-i18n - Internationalization and localization utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563481

Orcan 'oget' Ogetbil <oget.fedora at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |oget.fedora at gmail.com
         AssignedTo|nobody at fedoraproject.org    |oget.fedora at gmail.com
               Flag|                            |fedora-review+

--- Comment #2 from Orcan 'oget' Ogetbil <oget.fedora at gmail.com> 2010-02-21 01:46:37 EST ---
I reviewed this package. There are a few minor things but none of them are
blockers. Please read through and modify the specfile if there is need before
you commit


! rpmlint says:
   aduna-commons-i18n.src:123: W: libdir-macro-in-noarch-package (main package)
%attr(-,root,root) %{_libdir}/gcj/%{name}
       This can be ignored. By the way you can get rid of the
"%attr(-,root,root)" part

   aduna-commons-i18n.x86_64: W: no-documentation
       This can be ignored

   aduna-commons-i18n.x86_64: W: non-conffile-in-etc
/etc/maven/fragments/aduna-commons-i18n
       This can be ignored


! %description for javadoc subpackage should not be the same description for
the main package.


? This looks like a SUSE convention
   %{_javadocdir}/%{name}-%{version}
   %{_javadocdir}/%{name}
Do we have this in Fedora? If not, please remove the symlink.


! It looks like the following BR's are not really needed:
   BuildRequires: maven2
   BuildRequires: maven2-plugin-compiler
   BuildRequires: maven2-plugin-javadoc
   BuildRequires: maven-plugin-bundle
These will be pulled in by other dependencies so it won't do harm to leave them
but the following , I think, is absolutely not needed.
   BuildRequires: maven-surefire-provider-junit




-----------------------------------------------------
This package (aduna-commons-i18n) is APPROVED by oget
-----------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.