[Bug 565616] Review Request: libeina - Data Type Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565616

--- Comment #8 from Thomas Janssen <thomasj at fedoraproject.org> 2010-02-22 05:49:33 EST ---
Ok, stress is over, my brain is back working as expected.

- added missing BRs doxygen check

http://thomasj.fedorapeople.org/reviews/libeina.spec
http://thomasj.fedorapeople.org/reviews/libeina-0.9.9.063-5.fc12.src.rpm

Though, it fails to build at the test in mock and koji (even for F-12, that
works locally). And i have right now no idea why. Is this test badly needed?

http://koji.fedoraproject.org/koji/taskinfo?taskID=2004500

Following the test from my local build:

make  check-local
make[2]: Entering directory `/home/thomas/rpmbuild/BUILD/eina-0.9.9.063'
Running suite(s): Eina
 eina_test_log.c:37 eina_log_macro() Critical message

 eina_test_log.c:38 eina_log_macro() An error

CRI:MyDomain eina_test_log.c:54 eina_log_domains_macros() A critical message

ERR:MyDomain eina_test_log.c:55 eina_log_domains_macros() An error

-01:Levels eina_test_log.c:127 eina_log_level_indexes() Negative index message

you should have a safety check failure below:
ERR: eina_magic.c:249 eina_magic_string_set() safety check failed: magic_name
== NULL
you should have a safety check failure below:
ERR: eina_magic.c:249 eina_magic_string_set() safety check failed: magic_name
== NULL
you should see 'Input handle pointer is NULL' below
CRI: eina_test_magic.c:69 eina_magic_simple() *** Eina Magic Check Failed !!!
    Input handle pointer is NULL !
*** NAUGHTY PROGRAMMER!!!
*** SPANK SPANK SPANK!!!
*** Now go fix your code. Tut tut tut!


you should see 'Input handle has already been freed' below
CRI: eina_test_magic.c:79 eina_magic_simple() *** Eina Magic Check Failed !!!
    Input handle has already been freed!
*** NAUGHTY PROGRAMMER!!!
*** SPANK SPANK SPANK!!!
*** Now go fix your code. Tut tut tut!


you should see 'Input handle is wrong type' below
CRI: eina_test_magic.c:83 eina_magic_simple() *** Eina Magic Check Failed !!!
    Input handle is wrong type
    Expected: 7781fee7 - Eina Magic Test
    Supplied: 028757b2 - (null)
*** NAUGHTY PROGRAMMER!!!
*** SPANK SPANK SPANK!!!
*** Now go fix your code. Tut tut tut!


you should have a safety check failure below:
ERR: eina_inlist.c:414 eina_inlist_remove() safety check failed: list == NULL
you should have a safety check failure below:
ERR: eina_inlist.c:415 eina_inlist_remove() safety check failed: item == NULL
# specimen      experiment time starting time   ending time
100000  3777086 151459  3928545
200000  8644658 3929258 12573916
you should have a safety check failure below:
ERR: eina_counter.c:436 eina_counter_dump() safety check failed: counter ==
NULL
you should have a safety check failure below:
ERR: eina_file.c:247 eina_file_split() safety check failed: path == NULL
Run specimens_check: 1000
   0    1    2    3    4    5    6    7    8    9 
  10   11   12   13   14   15   16   17   18   19 
  20   21   22   23   24   25   26   27   28   29 
  30   31   32   33   34   35   36   37   38   39 
  40   41   42   43   44   45   46   47   48   49 
  50   51   52   53   54   55   56   57   58   59 
  60   61   62   63   64   65   66   67   68   69 
  70   71   72   73   74   75   76   77   78   79 
  80   81   82   83   84   85   86   87   88   89 
  90   91   92   93   94   95   96   97   98   99 
100%: Checks: 54, Failures: 0, Errors: 0
make[2]: Leaving directory `/home/thomas/rpmbuild/BUILD/eina-0.9.9.063'
make[1]: Leaving directory `/home/thomas/rpmbuild/BUILD/eina-0.9.9.063'
+ exit 0

It builds fine in mock and koji without the tests enabled.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.