[Bug 530747] Review Request: iodine - Solution to tunnel IPv4 data through a DNS server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530747

--- Comment #4 from Nikolay Ulyanitsky <lystor at lystor.org.ua> 2010-02-22 07:27:24 EST ---
> make %{?_smp_mflags} CFLAGS="-c -pedantic %{optflags} -DLINUX"
> You add compile flags and even do not comment for what. It is not permitted in
> Fedora: https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

1. "-c -pedantic -DLINUX" - upstream CFLAGS from src/Makefile
2. %{optflags} is required for Fedora


>> - Don't package README-win32.txt
> It have not many sense, but ok, I also do that.

https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation :
"Irrelevant documentation include build instructions, the omnipresent 
INSTALL file containing generic build instructions, for 
example, and documentation for non-Linux systems, e.g. README.MSDOS"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.