[Bug 564143] Review Request: fetch-crl - Downloads Certificate Revocation Lists

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=564143

Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review?

--- Comment #3 from Mattias Ellert <mattias.ellert at fysast.uu.se> 2010-02-22 07:26:43 EST ---
Fedora review fetch-url 2010-02-22

$ rpmlint *.rpm
fetch-crl.noarch: W: spelling-error %description -l en_US cron -> corn, con,
crone
fetch-crl.noarch: W: spelling-error %description -l en_US url -> URL, curl,
purl
fetch-crl.src: W: spelling-error %description -l en_US cron -> corn, con, crone
fetch-crl.src: W: spelling-error %description -l en_US url -> URL, curl, purl
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

Totally ignorable.

+ package name follows guidelines
+ specfile name after package
+ package license (EU Datagrid) is Fedora approved
+ package license matches license statements in the sources
+ no LICENSE file in sources, the README file does mention the license though
  and this is included as %doc
+ specfile is written in legible English

3004316879 19081 fetch-crl-2.8.1.tar.gz
3004316879 19081 srpm/fetch-crl-2.8.1.tar.gz

+ source matches upstream
+ package builds in mock (Fedora 12)
+ package owns directories it creates
+ no duplicates in %files
+ permissions are sane and %files has %defattr
+ %clean clears buildroot

? minor inconsistent use of macros: e.g. there is both
  fetch-crl-%{version} and %{name}-%{version} used
  redundant / in $RPM_BUILD_ROOT/%{_sysconfdir}
  redundant / in $RPM_BUILD_ROOT/%{_initddir}

+ package does not own other's directories
+ %install clears buildroot
+ filenames are utf-8

There seems to be copies of files in %doc that are already installed
elsewhere for no clear reason. I would suggest removing the copies in %doc.

$ cksum /usr/share/doc/fetch-crl-2.8.1/fetch-crl-boot.init
/etc/rc.d/init.d/fetch-crl-boot 
1589392885 1219 /usr/share/doc/fetch-crl-2.8.1/fetch-crl-boot.init
1589392885 1219 /etc/rc.d/init.d/fetch-crl-boot
$ cksum /usr/share/doc/fetch-crl-2.8.1/fetch-crl-cron.cron
/etc/cron.d/fetch-crl.cron 
1021051804 348 /usr/share/doc/fetch-crl-2.8.1/fetch-crl-cron.cron
1021051804 348 /etc/cron.d/fetch-crl.cron
$ cksum /usr/share/doc/fetch-crl-2.8.1/fetch-crl-cron.init
/etc/rc.d/init.d/fetch-crl-cron 
3689563854 1020 /usr/share/doc/fetch-crl-2.8.1/fetch-crl-cron.init
3689563854 1020 /etc/rc.d/init.d/fetch-crl-cron
$ cksum /usr/share/doc/fetch-crl-2.8.1/fetch-crl.sysconfig /etc/fetch-crl.conf 
784442183 2213 /usr/share/doc/fetch-crl-2.8.1/fetch-crl.sysconfig
784442183 2213 /etc/fetch-crl.conf

Some implementations on cron ignore files in /etc/cron.d that have
periods in the filename. The default Fedora cron does not do this, but
for better portability you might want to drop the .cron extension from
/etc/cron.d/fetch-crl.cron

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.