[Bug 567053] Review Request: uzbl - Lightweight WebKit browser following the UNIX philosophy

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567053

--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-22 12:11:31 EST ---
Some notes:

* Epoch
  - Please don't introduce Epoch

* Make build log more verbose
  - Build log messages like:
-------------------------------------------------------------
    38  + make -j4
    39  COMPILING src/callbacks.c
    40  COMPILING src/events.c
    41  COMPILING src/inspector.c
    42  COMPILING src/uzbl-core.c
    43  ... done.
-------------------------------------------------------------
    is not useful. We cannot check what is actually happening here,
    especially we cannot check if Fedora specific compilation flags
    are correctly honored or not:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

    Please build log more verbose so that we can check if compiler
    flags are correctly honored.
    ! Note
      As far as I checked this package, actually Fedora specific compilation
      flags are currently not correctly honored, so this needs fixing.

* Build failure
  - Your srpm does not build on F-13:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2005910
    This is because F-13 changed the options to pass to linker:
    http://lists.fedoraproject.org/pipermail/devel/2010-February/130519.html
    https://fedoraproject.org/wiki/UnderstandingDSOLinkChange

    You can check this by passing "--no-added" option to linker
    (for this package, you can do by doing $ make CC="gcc -Wl,--no-added")

* %makeinstall
  - Please avoid using this unless impossible:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

* Macros
  - Please use rpmmacros. /usr should be %{_prefix}
    https://fedoraproject.org/wiki/Packaging/RPMMacros

* Desktop files
  - GUI application should install proper desktop files:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

* Directories for document files
  - Currently this package installs document files under:
    - /usr/share/doc/uzbl-0
    - /usr/share/uzbl/docs
    - /usr/share/uzbl/examples
    Please consider to unify these (especially "AUTHORS" or so are installed
    both under the first two directories, so these should be fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.