[Bug 566163] Review Request: sugar-logos - Boot splash imagery for Sugar on a Stick

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566163

--- Comment #2 from Sebastian Dziallas <sebastian at when.com> 2010-02-22 16:42:57 EST ---
(In reply to comment #1)

Thanks for taking on this one! ;)

> Issues:
> 
> Is this GPLv2 or GPLv2+? I couldn't find any info in the source. You are the
> author, please clarify the license and add an AUTHORS file in the next release.

Well,
http://git.sugarlabs.org/projects/sugar-logos/repos/mainline/blobs/master/COPYING
says that "the images in sugar-logos are licensed as GPLv2+." but I guess that
could be improved, indeed.

I'll add an AUTHORS file for the next release (which should happen soon anyway,
as we need some new stuff for v3).

> I wonder if "sugar-logos" is the proper name for this package. Usually a
> *-logos package contains *all* the branding. Is this already sufficient for
> SOAS or are you planning to enhance the source with more graphics so it becomes
> a full counterpart to fedora-logos/generic-logos? If so, you need to add
> "Provides: system-logos".
> IMHO this package should be named "plymouth-theme-sugar" to be in line with the
> rest of our packages. Even if you include more icons in the source, you should
> package the plymouth theme separately I think.

I was thinking about this, too. This package is currently not a full
counter-part to fedora-logos and such. However, it might contain additional
images and related stuff in the future.

http://cvs.fedoraproject.org/viewvc/devel/fedora-logos/fedora-logos.spec?view=markup
also contains the plymouth images which is why I originally went with this
naming.

> soas.plymouth contains a hardcoded path with /usr/share/. Fix this upstream.    

http://cvs.fedoraproject.org/viewvc/devel/plymouth/charge.plymouth?view=markup
does the same thing (which admittedly isn't exactly an argument for doing it,
though) - the files it links to will always live in that path.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.