[Bug 566962] Review Request: polipo - Lightweight Caching Web Proxy

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 23 02:15:14 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=566962

--- Comment #7 from Chen Lei <supercyper at 163.com> 2010-02-22 21:15:12 EST ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> 
> > > > [-] MUST: A package must own all directories that it creates. If it does not
> > > > create a directory that it uses, then it should require a package which does
> > > > create that directory.
> > > 
> > > How to fix it? I think I already own all directories.
> > > 
> > Your spec creates some directories via mkdir. are they owned by your package as
> > well?
> 
> There is probably a misunderstanding. I did not look at the final RPMs, so I
> did not check whether all directories are owned. But the guideline is targeted
> at the directories that are created when the RPM is installed, e.g. if the SPEC
> contains "mkdir %{_bindir}", this does not count as a created directory,
> because this directory is already included in the filesystem RPM.
> 
> Btw. there are two trailing tab chars after the "Requires: logrotate", that can
> be removed, but there is no need to do this immediately.    

Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list