[Bug 567668] New: aide package rebase

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: aide package rebase

https://bugzilla.redhat.com/show_bug.cgi?id=567668

           Summary: aide package rebase
           Product: Red Hat Enterprise Linux 6
           Version: 6.1
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: aide
        AssignedTo: sgrubb at redhat.com
        ReportedBy: sgrubb at redhat.com
         QAContact: qe-baseos-security at redhat.com
                CC: notting at redhat.com, mitr at redhat.com,
                    sgrubb at redhat.com, fedora-package-review at redhat.com
        Depends on: 561128
             Group: rhel_beta
   Estimated Hours: 0.0
    Classification: Red Hat
    Target Release: ---
          Clone Of: 561128


+++ This bug was initially created as a clone of Bug #561128 +++

(There probably used to be a review in Extras.)

* Licensing problems:
  * src/fopen.c contains:
    > 2. Redistributions in binary form must reproduce the above copyright
    >    notice, this list of conditions and the following disclaimer in the
    >    documentation and/or other materials provided with the distribution.
    - the BSD advertising clause, incompatible with GPL
  * src/snprintf.c uses the "Frontier Artistic License", AFAICS never approved
    for Fedora (http://fedoraproject.org/wiki/Licensing)
  (In both cases the functionality is probably unnecessary and the files could
  be removed from the source tarball)
  * LICENSE-snprintf.txt is not provided in %doc

* rpmlint:
  > aide.x86_64: W: log-files-without-logrotate /var/log/aide
  Can the log file grow without bounds?

* Uses %makeinstall, is it necessary? Makefile.in seems to support DESTDIR.

* Uses %define, should use %global instead

* Low-severity:
  * The "nostatic" macro is defined, but not used
  *
https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

--- Additional comment from sgrubb at redhat.com on 2010-02-19 13:34:20 EST ---

All findings have been addressed in aide-0.13.1-16 except the license issues.
This is going to be handled by a new upstream release.

--- Additional comment from sgrubb at redhat.com on 2010-02-22 20:23:42 EST ---

aide-0.14-0.1.rc1 was built to address all problems found in this package
review. Please let me know if there is anything else that needs attention.
Thanks.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.