[Bug 561448] Review Request: jffi - Java Foreign Function Interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=561448

--- Comment #4 from Mohammed Morsi <mmorsi at redhat.com> 2010-02-23 16:54:19 EST ---
(In reply to comment #3)
> For 0.6.5-1:
> 
> * Compilation issue
>   A First of all, now build fails:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=1996972
>     This is because -Werror.

Patched the source to remove -Werror

> 
>   B Even after -Werror is removed, build fails on ppc64:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=1997040
>     The failing command is:
>     Well, -m32 is wrong for ppc64. This is because {jni/libtest}/GNUmakefile
>     does not check if the arch is ppc64 or not.... however
>     this check is anyway not needed anyway.

I see the same thing, this isn't a blocker since it builds fine of i686 and
x86_64 correct?

> 
> * Test
>   - Forgot to mention this, however please check if some test programs
>     are available or not (as this package contains test/ directory)
> 

Package now includes a check section which runs the test suite. All tests run
fine.

> * Empty debuginfo
> -----------------------------------------------------------------------
> jffi-debuginfo.i686: E: debuginfo-without-sources
> -----------------------------------------------------------------------
>   - Well, I don't know how Java packages treat this by default,
>     however generally to create debuginfo rpm corretly, libjffi-0.6.so
>     should not be stripped in build process itself and should
>     be handled by find-debuginfo.sh and so on.    

I'm not getting this error. Instead I get 

W: unstripped-binary-or-object /usr/lib/jffi/libjffi-0.6.so

Removing the call to "strip" in the makefile and marking the shared object as
executable does not seem to generate the debuginfo package as detailed online.
Unless you know of the fix, I'm leaving this as is as there seem to be other
packages that have been approved / accepted in lieu of this warning.

Update spec and srpm:
Spec URL: http://mo.morsi.org/files/jruby/jffi.spec
SRPM URL: http://mo.morsi.org/files/jruby/jffi-0.6.5-2.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.