[Bug 563013] Review Request: gnome-applet-remmina - GNOME panel applet for Remmina remote desktop client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=563013

Naveen Kumar <nkumar at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nkumar at redhat.com

--- Comment #1 from Naveen Kumar <nkumar at redhat.com> 2010-02-24 02:17:56 EST ---
Here's an unofficial review, using the Tibbs checklist as reference from:
http://fedoraproject.org/wiki/User:Tibbs/Review_Template


- source files do not match upstream: I could not locate specified tarball (in
specfile) at upstream location. Hence no checksum test.
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible: license text included in package.
- latest version is being packaged. (The upstream seems to have deleted older
version and released newer version of upstream tarball)
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in Koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=2004538
+ debuginfo package looks complete.
* rpmlint is not silent: output with warnings and no errors: (rpmlint version
0.94)

 rpmlint OUTPUT on gnome-applet-remmina-0.7.1-1.fc13.src.rpm:
gnome-applet-remmina.src: W: spelling-error %description -l en_US travellers ->
travelers, traveler, travelogues
gnome-applet-remmina.src: W: spelling-error %description -l en_US netbooks ->
net books, net-books, pocketbooks
gnome-applet-remmina.src: W: invalid-url Source0:
http://downloads.sourceforge.net/remmina/remmina-gnome-0.7.1.tar.gz HTTP Error
404: Not Found
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

 rpmlint OUTPUT on gnome-applet-remmina-0.7.1-1.fc13.x86_64.rpm:
gnome-applet-remmina.x86_64: W: spelling-error %description -l en_US travellers
-> travelers, traveler, travelogues
gnome-applet-remmina.x86_64: W: spelling-error %description -l en_US netbooks
-> net books, net-books, pocketbooks
gnome-applet-remmina.x86_64: W: incoherent-version-in-changelog 0.7.1
['0.7.1-1.fc13', '0.7.1-1']
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

 rpmlint OUTPUT on gnome-applet-remmina-debuginfo-0.7.1-1.fc13.x86_64.rpm:
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:

     rpm -qp --provides OUTPUT on gnome-applet-remmina-0.7.1-1.fc13.x86_64.rpm:
gnome-applet-grdc = 0.7.1
grdc-gnome = 0.7.1
remmina-gnome = 0.7.1
gnome-applet-remmina = 0.7.1-1.fc13
gnome-applet-remmina(x86-64) = 0.7.1-1.fc13

     rpm -qp --requires OUTPUT on gnome-applet-remmina-0.7.1-1.fc13.x86_64.rpm:
gnome-panel  
libORBit-2.so.0()(64bit)  
libart_lgpl_2.so.2()(64bit)  
libatk-1.0.so.0()(64bit)  
libavahi-client.so.3()(64bit)  
libavahi-common.so.3()(64bit)  
libbonobo-2.so.0()(64bit)  
libbonobo-activation.so.4()(64bit)  
libbonoboui-2.so.0()(64bit)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libcairo.so.2()(64bit)  
libfontconfig.so.1()(64bit)  
libfreetype.so.6()(64bit)  
libgconf-2.so.4()(64bit)  
libgdk-x11-2.0.so.0()(64bit)  
libgdk_pixbuf-2.0.so.0()(64bit)  
libgio-2.0.so.0()(64bit)  
libglib-2.0.so.0()(64bit)  
libgmodule-2.0.so.0()(64bit)  
libgnome-2.so.0()(64bit)  
libgnomecanvas-2.so.0()(64bit)  
libgobject-2.0.so.0()(64bit)  
libgthread-2.0.so.0()(64bit)  
libgtk-x11-2.0.so.0()(64bit)  
libpanel-applet-2.so.0()(64bit)  
libpango-1.0.so.0()(64bit)  
libpangocairo-1.0.so.0()(64bit)  
libpangoft2-1.0.so.0()(64bit)  
libpopt.so.0()(64bit)  
libpthread.so.0()(64bit)  
librt.so.1()(64bit)  
remmina >= 0.7.1
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1
rtld(GNU_HASH)  
rpmlib(PayloadIsXz) <= 5.2-1


+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ scriptlets sane
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
- No %docs section
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
- I could not locate desktop (.desktop) files

Additional Comments:-
* The upstream seems to have deleted older version and released newer version
of upstream tarball. Can you update your Specfile and SRPMS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.