[Bug 544684] Review Request: gqradio - Skinned radio tuner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544684

Thomas Janssen <thomasj at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #9 from Thomas Janssen <thomasj at fedoraproject.org> 2010-02-25 07:54:14 EST ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
XX - License field in spec matches
XX - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
10fded1c080cadd1b260a592772bcbb6  gqradio-1.9.2.tar.gz
NN - Package needs ExcludeArch
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
NN - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

NN - Headers/static libs in -devel subpackage.
NN - Spec has needed ldconfig in post and postun
NN - .pc files in -devel subpackage/requires pkgconfig
NN - .so files in -devel subpackage.
NN - -devel package Requires: %{name} = %{version}-%{release}
NN - .la files are removed.

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
Just one bogus spelling warning.
NN - final provides and requires are sane:

SHOULD Items:                                                                   

OK - Should build in mock.                                                      
OK - Should build on all supported archs                                        
OK - Should function as described.                                             
                                                                               
                                          OK - Should have sane scriptlets.     
NN - Should have subpackages require base package with fully versioned depend.  
OK - Should have dist tag                                                       
OK - Should package latest version                                              


Issues:
Remove the INSTALL file from %doc. It's only needed for compiling/installation.

Update %changelog ;) It's missing the entry for the latest release bump.

The license in the source says GPL, so that would be a GPL+, but the COPYING
included in the tarball says GPLv2. Please update the license filed in your
spec to: GPL+

Fix the 3 issues mentioned above and the package will be approved :)

After i installed it i tried to run it:
[thomas at tusdell srpm-review-test]$ gqradio 
Creating dir:/home/thomas/.gqradio
Creating dir:/home/thomas/.gqradio/skins
Failed to find /dev/radio
Radio device control test failed
Error, radio support missing, or failed to init radio device!
unable to open /dev/mixer

I guess that's expected since i dont have a radio tuner in my system. I will
try and see if it uses my dvb-t radio thing, but i doubt that ;)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.