[Bug 567111] Review Request: libunicapgtk - Library to build graphical widgets for the unicap library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=567111

Thomas Janssen <thomasj at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+

--- Comment #1 from Thomas Janssen <thomasj at fedoraproject.org> 2010-02-25 08:43:26 EST ---
Ok, this is a re-review request due to upstream name change.

OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
e801de57a9f37bffd892016d319a6a62  libunicapgtk-0.9.8.tar.gz
NN - Package needs ExcludeArch
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
OK - Package is code or permissible content.
OK - Doc subpackage needed/used.
OK - Packages %doc files don't affect runtime.

OK - Headers/static libs in -devel subpackage.
OK - Spec has needed ldconfig in post and postun
OK - .pc files in -devel subpackage/requires pkgconfig
OK - .so files in -devel subpackage.
OK - -devel package Requires: %{name} = %{version}-%{release}
OK - .la files are removed.

NN - Package is a GUI app and has a .desktop file

OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - No rpmlint output.
[thomas at tusdell srpm-review-test]$ rpmlint libunicapgtk.spec
libunicapgtk-0.9.8-1.src.rpm 
libunicapgtk.src: W: spelling-error Summary(en_US) unicap -> uncap, uni cap,
uni-cap
libunicapgtk.src: W: spelling-error %description -l en_US Unicap -> Uncap, Uni
cap, Uni-cap
libunicapgtk.src: W: spelling-error %description -l en_US unicapGTK ->
unicameral, unification, unicellular
1 packages and 1 specfiles checked; 0 errors, 3 warnings.
Only bogus warnings, can be ignored.



I have checked for obsoletes and provides. I had a chat in IRC with the
maintainer and this seems to be the sane way                       

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.