[Bug 559699] Review Request: RE-REVIEW of qpid-cpp (rename of qpidc)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=559699

--- Comment #8 from Nuno Santos <nsantos at redhat.com> 2010-02-25 13:30:48 EST ---
(In reply to comment #7)

For the sake of completeness, I've uploaded new versions of the SRPM and the
specfile to the same URLs, to address the comments above.

>> * qpid-cpp-server.i686: E: non-readable /var/lib/qpidd/qpidd.sasldb 0600
>>   - this is supposed to non-readble
> 
> Ok, I can see that in the spec file too and it is OK, but generally is a good
> idea to document in the spec file why.
>
>> * qpid-cpp-server-store.i686: E: non-standard-dir-perm /var/rhm 0775
>>   - supposed to have those permissions
> 
> same as above.. document why.

Done, added the following comments to the specfile:

# qpidd.sasldb contains sasl credentials, needs to be readable only by root
%attr(600, qpidd, qpidd) %config(noreplace)
%_localstatedir/lib/qpidd/qpidd.sasldb

and

# /var/rhm needs to be group writable so that journal files can be updated
properly
%attr(0775,qpidd,qpidd) %dir %_localstatedir/rhm


>> * qpid-cpp-server-store.i686: E: explicit-lib-dependency libaio
>>   - there is no explicit lib dependency, there is a requires for a package
>>     named libaio: "Requires: libaio" (line 281)
> 
> You have to drop the explicit Requires: libaio. rpm dependency resolver will
> add that automatically for you.

Done.

> So just to make this quick, I´ll approve the rename of the package, but please
> fix those bits when importing into cvs.

Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.