[Bug 568428] Review Request: libldb - A schema-less, ldap like, API and database

bugzilla at redhat.com bugzilla at redhat.com
Thu Feb 25 19:53:21 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=568428

--- Comment #3 from Simo Sorce <ssorce at redhat.com> 2010-02-25 14:53:19 EST ---
Looks like the prepping of the %install step does not conform to guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines

Removal of the build root is absent (required for EPEL, not required for Fedora
> 10

 %{buildroot} should be preferred to $RPM_BUILD_ROOT so that variables are used
consistently throughout the spec file.

The rest looks good to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list