[Bug 508750] Review Request: trash-cli - Command line interface to the freedesktop.org trashcan

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508750

--- Comment #17 from David A. Wheeler <dwheeler at dwheeler.com> 2010-02-25 17:50:12 EST ---
I think the source RPM URL, as given by comment #14, isn't right.  That URL
implies a release number of 1 (but we're at 2!), and the release number given
by it (once installed) is clearly 1 and not 2.

I installed the source RPM from comment #14 by doing:
 cd ~/temp
 rm trash-cli*
 wget http://sundaram.fedorapeople.org/packages/trash-cli-0.11.2-1.fc12.src.rpm
 rpm -i trash-cli*

Note that the filename has a "-1" release number! Running:
  grep 'Release:' ~/rpmbuild/SPECS/trash-cli.spec
shows:
 Release: 1
which conflicts with the %changelog in the same .spec file.

Interestingly, if I just look at the *spec* file URL from comment #14:
 http://sundaram.fedorapeople.org/packages/trash-cli.spec
Then that *does* have "Release: 2".

So, I think the file you're asking me to review is not the one you actually
wanted me to review :-).

Also: The %description isn't right.  You *cannot* use "trash" as a replacement
for "rm", you have to use "trash-put".  I'm not a fan of renaming this
executable, but if you're going to do that, the %description in the spec file
should be correct.

You're *really close*!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.