[Bug 556346] Review Request: stage - A 2.5D multi-robot simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=556346

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-27 13:00:18 EST ---
Checked -3.

Some notes:

* SourceURL
  - For sourceforge hosted tarball, please follow
    https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

* BR (BuildRequires) for mesa related packages
  - For historical reason we prefer to use virtually provided dependency
    to (Build)Requires like "BuildRequires: libGL(U)-devel" instead of
    using rpm name directly.

* Requires for -devel subpackage
  - Installed stage.pc contains:
-----------------------------------------------------------------------
     7  Libs: -L${prefix}/lib -lstage -lfltk_images -lpng -lz -ljpeg -lfltk_gl
-lGLU -lGL -lfltk
     8  Cflags: -I${prefix}/include/Stage-3.2 -I/usr/include/freetype2
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_THREAD_SAFE 
-----------------------------------------------------------------------
    This means -devel subpackage should have 
    "Requires: fltk-devel libpng-devel libjpeg-devel libGL-devel libGLU-devel"
    ( zlib-devel is pulled in by libpng-devel", freetype-devel is pulled in by
      fltk-devel )

! BuildRequires in one place
  - This is not a blocker, however it is more readable to write all
    BuildRequires in one place instead of seperating them into some
    subpackages.

* pkgconfig Requires
  - Explicitly writing "Requires: pkgconfig" is no longer needed on
    Fedora 11 and above.

* Macros
  - Use macros correctly. /usr/share should be %{_datadir}:
    https://fedoraproject.org/wiki/Packaging/RPMMacros

* Build failure
  - Your srpm fails to build on F-13:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2017917
    This is because Fedora 13 changed the behavior of linker:
    http://fedoraproject.org/wiki/UnderstandingDSOLinkChange

    To check F-13 linker behavior on F-12/11, you can do this by adding
-------------------------------------------------------------
export LDFLAGS="-Wl,--no-add-needed"
-------------------------------------------------------------
  before %cmake line.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.