[Bug 565376] Review Request: qstardict - StarDict clone written in Qt4

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=565376

Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp

--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2010-02-27 15:37:58 EST ---
>From next time please change the release number every time
you modify your spec file (unless version number changes)

Some notes:

* License
  - License tag should be "GPLv2+" (the developer can change the
    license freely even from GPLv3, if all the contributor for
    the source codes agree it)

* BuildRequires
  - qt-devel is pulled in by kdelibs-devel, so explicitly writing
    "BR: qt-devel" is not needed.

  - Also using vitrual dependency related BuildRequires is preferable
    (i.e. "BR: kdelibs4-devel" is preferable)

? Enabled plugin
  - Would you explain why you enable only "stardict web" plugins?

* Macros
  - Choose %{__make} or make, not use both.

* %defattr
  - Now we prefer to use %defattr(-,root,root,-)

* Build failure
  - Your srpm does not build on F-13:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2018034
    This is because Fedora 13 changed the behavior of linker:
    http://fedoraproject.org/wiki/UnderstandingDSOLinkChange

    To check F-13 linker behavior on F-12/11, you can do this by
    'make %{?_smp_mflags} LINK="g++ -Wl,--no-add-needed"' for
    this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.