[Bug 551915] Review Request: monodevelop-debugger-gdb - A gdb debugger addin for monodevelop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551915

--- Comment #6 from Christian Krause <chkr at plauener.de> 2010-02-28 15:31:45 EST ---
* rpmlint: TODO
rpmlint RPMS/i686/monodevelop-debugger-gdb-2.2.1-1.fc13.i686.rpm
SRPMS/monodevelop-debugger-gdb-2.2.1-1.fc13.src.rpm
SPECS/monodevelop-debugger-gdb.spec 
monodevelop-debugger-gdb.i686: W: spelling-error Summary(en_US) Addin -> Addie,
Adding, Admin
monodevelop-debugger-gdb.i686: W: spelling-error %description -l en_US Addin ->
Addie, Adding, Admin
monodevelop-debugger-gdb.i686: E: no-binary
monodevelop-debugger-gdb.i686: W: only-non-binary-in-usr-lib
monodevelop-debugger-gdb.i686: W: no-documentation
monodevelop-debugger-gdb.src: W: spelling-error Summary(en_US) Addin -> Addie,
Adding, Admin
monodevelop-debugger-gdb.src: W: spelling-error %description -l en_US Addin ->
Addie, Adding, Admin
monodevelop-debugger-gdb.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line
4, tab: line 10)
SPECS/monodevelop-debugger-gdb.spec:10: W: mixed-use-of-spaces-and-tabs
(spaces: line 4, tab: line 10)
2 packages and 1 specfiles checked; 1 errors, 8 warnings.

- no-binary, no-documentation and only-non-binary-in-usr-lib are false
positives
- mixed-use-of-spaces-and-tabs should be fixed
- spelling errors: "Addin" should be written "Add-in" (as it is done in
monodevelop as well as on its web page)

* naming: OK
- name matches upstream
- spec file name matches package name

* sources: OK
- md5sum: 33af29187c122ff29b28d77ef889c37e 
monodevelop-debugger-gdb-2.2.1.tar.bz2
- sources matches upstream
- Source0 tag ok
- spectool -g  works

* binaries in upstream sources: OK (n/a)

* License: TODO
- License in spec file does not match the actual license, the source files
indicate an MIT license
- Please ask upstream to include a license file

* package containing *.pc files must "Requires: pkgconfig": OK (n/a)

* spec file written in English and legible: minor TODOs
- please split the long line of the BuildRequires so that it fit into
80 characters for better readability
- please append a "/" to the URL to get a 100% correct URL ;-)

* compilation: TODO
- please check whether the package does support a parallel build, if not please
add a short comment in the %build section
- builds fine in koji: F14

* BuildRequires: TODO
- it looks like that "gdb" as a BR is not necessary

* Requires: TODO
- please add "Requires: gdb" to ensure that there are no strange
error message when trying to use the gdb debugger inside monodevelop
without having gdb actually installed

* locales handling: OK (n/a)

* ldconfig in %post and %postun: OK (n/a)

* package owns all directories that it creates: OK

* %files section: OK

* no files listed twice in %files: OK

* file permissions: OK
- %defattr used
- actual permissions in packages ok

* %clean section: OK

* macro usage: OK

* code vs. content: OK

* main package should not contain development related parts: OK (n/a)

* large documentation into subpackage: OK (n/a)

* header files in -devel subpackage: OK (n/a)

* static libraries in -static package: OK (n/a)

* *.so link in -devel package: OK (n/a)

* devel package requires base package using fully versioned dependency: OK
(n/a)

* packages must not contain *.la files: OK (n/a)

* GUI applications must provide *.desktop file: OK (n/a)

* packages must not own files/dirs already owned by other packages: OK

* rm -rf $RPM_BUILD_ROOT at the beginning of %install: OK

* all filenames UTF-8: OK

* functional test: OK

* debuginfo sub-package: OK (n/a)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.