[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838


ELMORABITY Mohamed <melmorabity at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |melmorabity at fedoraproject.o
                   |                            |rg




--- Comment #1 from ELMORABITY Mohamed <melmorabity at fedoraproject.org>  2010-01-02 10:46:52 EDT ---
Hi,

here is an informal review of your package, while waiting to be sponsored ^^.
Just a few remarks about BR, the general look of the .spec seems pretty good
^^.

* since glibc-devel is a dependancy of gcc,
and since gcc is part of the minimal build system in Fedora (see
https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2), there is no
need to set glibc-devel as a BuildRequires.

* However, after checking the configure.in, I think you'll need to set
perl-devel as a BuildRequires.

* By the way, according to the file configure.in, the BR libcap-devel is only
required if the option « --enable-switch_user » is explicitely called.
Otherwise it is useless.
If you think that this option is useful, it may be a good thing to enable it,
to offer as many enabled features as possible in your binary.

You should check that you have defined all the required BuildRequires with
mock:
   http://fedoraproject.org/wiki/Extras/MockTricks

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.