[Bug 546301] Review Request: moblin-app-installer - Moblin Application Installer

bugzilla at redhat.com bugzilla at redhat.com
Sun Jan 3 00:52:03 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=546301





--- Comment #3 from Peter Robinson <pbrobinson at gmail.com>  2010-01-02 19:52:02 EDT ---

> Issues:
> - Missing docs: AUTHORS NEWS README TODO
> 
> - BR gtk2-devel is redundant
> 
> - no need to patch the desktop file, you can do this with desktop-file-install
> --remove-key ... If you patch it, please use the upstream patch from
> http://git.moblin.org/cgit.cgi/moblin-app-installer/commit/?id=bc65c884d3a1ae37e69431417888126b2a3ea021
> 
> - applist.xml contains lots of packages that are not part of Fedora. At least
> the closed source apps like AdobeReader or World of Go should IMO be removed.
> Other packages need their names fixed (like kanagram, khangman and kiten which
> are part of the kdeedu package).
> 
> - applist.xml should be packaged as separate package, see README  

Updated SRPM:
http://pbrobinson.fedorapeople.org/moblin-app-installer-0.4.0-0.3.fc12.src.rpm

Fixed all of the above. Dropped the applist.xml file and will look at what's
required to package separately or use local repos.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list