[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838





--- Comment #3 from ELMORABITY Mohamed <melmorabity at fedoraproject.org>  2010-01-03 10:25:20 EDT ---
> perl-ExtUtils-Embed needs perl-devel as its dependency, so i have not included
> it in BuildRequires.
You're right, excellent :)

mock runs find indeed, and rpmlint is silent on your SRPM, your binary RPM and
the debuginfo one.
I don't see any problem, I think your RPM is OK :-)

Just a little comment about the Group tag: isn't it more appropriate to set it
to "
Applications/Internet"?
Just my personal opinion about your Description also, but I find it a little
bit "laconic" ^^. Maybe you could use the description provided on the opendchub
home page to make it more precise ^^.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.