[Bug 545039] Review Request: xulrunner-python - Files needed to run Gecko applications written in python.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545039





--- Comment #2 from Martin Stransky <stransky at redhat.com>  2010-01-05 04:49:08 EDT ---
Thanks for the comments!

(In reply to comment #1)
> Just a few comments for now:
> - Why do you use add_files and not the normal %files section?

Because the file list is dynamically generated from pkg-config and depends on
recently installed xulrunner package.

> - Why do you install in a own created directory and don't use $RPM_BUILD_ROOT?

$RPM_BUILD_ROOT is used...see add_files() macro. the %{builddir} is only a
shortcut.

> - nspr_version is not existent. Is it even needed?  

Ahh, good point, nspr_version has to be added.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.