[Bug 538465] Review Request: libmx - A clutter widget toolkit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538465


Sebastian Dziallas <sebastian at when.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #11 from Sebastian Dziallas <sebastian at when.com>  2010-01-05 08:38:21 EDT ---
[  OK  ] specfiles match: 5b84e5e23a3ed18216bb0c4e8d8961db
[  OK  ] source files match upstream: 916694e534ae745d3a809c4634b6696f
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  OK  ] compiler flags are appropriate.
[  OK  ] %clean is present.
[  OK  ] package builds in mock:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1902982
[  OK  ] package installs properly.
[  OK  ] debuginfo package looks complete.
[  OK  ] rpmlint is silent: libmx-devel.i686: W: no-documentation
[  OK  ] final provides and requires are sane
[  NA  ] %check is present and all tests pass
[  OK  ] no shared libraries are added to the regular linker search paths.
[  NA  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  NA  ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] docs subpackage is appropriately created
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] headers go into devel package.
[  OK  ] pkgconfig files are in devel package.
[  OK  ] no libtool .la droppings.
[  NA  ] desktop files valid and installed properly.

Looks like you're good to go here. The rpmlint warning is a non-issue, since
the devel package pulls the main package in anyway. So this is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.