[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mtasaka at ioa.s.u-tokyo.ac.jp
               Flag|                            |fedora-review?




--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2010-01-06 10:34:36 EDT ---
Well,

* perl module dependency
  https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides
  - When writing perl module rpm dependency as (Build)Requires,
    use the virtual provides on the package, not the rpm name itself
    (i.e. use "BuildRequires: perl(ExtUtils::Embed)"

* creating directory under home directory
  - configure.in reads:
-----------------------------------------------------------
    60  dnl Check if config directory exists.
    61  if test ! -d $HOME/.opendchub; then
    62     echo "creating config directory: $HOME/.opendchub"
    63     mkdir $HOME/.opendchub
    64     chmod 700 $HOME/.opendchub;
    65  fi
    66  
    75  if test "$ENABLE_PERL" = "yes"; then
    76     AC_CHECK_PROG(ENABLE_PERL, perl, yes, no)
    77     if test "$ENABLE_PERL" = "no"; then
    78        AC_MSG_WARN(Perl wasn't found. Scripting will be disabled.)
    79     else
    85         dnl Check if script directory exists.
    86         dnl Creates it and copies sample scripts to it if it doesn't.
    87         if test ! -d $HOME/.opendchub/scripts; then
    88            echo "creating script directory: $HOME/.opendchub/scripts"
    89            mkdir $HOME/.opendchub/scripts
    90            chmod 700 $HOME/.opendchub/scripts;
    91            for i in Samplescripts/*; do
    92                cp $i $HOME/.opendchub/scripts;
    93            done
    94         fi       
    95     fi
    96  else
    97      echo "Perl script support is disabled."
    98  fi
-----------------------------------------------------------
    and build.log says:
-----------------------------------------------------------
   129  Switch user support is enabled.
   130  creating config directory: /builddir/.opendchub
   131  checking for perl... yes
   132  creating script directory: /builddir/.opendchub/scripts
-----------------------------------------------------------
    Well,
    - build process should not create any directories under home
      directory. If these directories are needed, they should be
      created when the program is actually executed.
      Also Fedora forbids to create directories under home directory
      during build process:
     
https://fedoraproject.org/wiki/Packaging/Guidelines#Scriplets_are_only_allowed_to_write_in_certain_directories

    - Furthermore, these created directories are not installed
      when installing this software with rpm anyway.

    So this behavior (i.e creating directories under home directory
    and installing some scripts under there during build) should
    be suppressed.
    - By the way maybe Samplescripts/ should be included as %doc.

* %changelog
  - It is recommended (and useful when using Fedora CVS) to insert
    one line between each %changelog entry like:
---------------------------------------------------------
* Sun Jan 3 2009 Roshan Kumar Singh <singh.roshan08 at gmail.com> 0.8.1-3
- Changed Group to a more appropriate one

* Sun Jan 3 2009 Roshan Kumar Singh <singh.roshan08 at gmail.com> 0.8.1-2
- Removed glibc-devel and added perl-devel to BR and changed configure

* Sat Jan 2 2009 Roshan Kumar Singh <singh.roshan08 at gmail.com> 0.8.1-1
- First RPM for opendchub
---------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.