[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838





--- Comment #6 from Roshan Singh <singh.roshan08 at gmail.com>  2010-01-06 22:23:47 EDT ---
(In reply to comment #5)

> * perl module dependency
>   https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides
>   - When writing perl module rpm dependency as (Build)Requires,
>     use the virtual provides on the package, not the rpm name itself
>     (i.e. use "BuildRequires: perl(ExtUtils::Embed)"

Done! The very next line in the above links says "packages link to libperl.so,
usually to provide embedded perl functionality. All of these packages must also
use the versioned MODULE_COMPAT Requires. " So I think this is needed as well

Requires:  perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version))

> 
> * creating directory under home directory
[snip]
>     Well,
>     - build process should not create any directories under home
>       directory. If these directories are needed, they should be
>       created when the program is actually executed.

The binary also creates the directories. I will remove this thing in the next
release.


>     So this behavior (i.e creating directories under home directory
>     and installing some scripts under there during build) should
>     be suppressed.

I have done this by 

%build
%configure --enable-switch_user
rm -rf $HOME/.opendchub

Is it okay ?

Other changes have also been made. I will renew the SPEC after you confirm the
changes.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.