[Bug 548694] Review Request: python-rpmfluff - Lightweight way of building RPMs, and sabotaging them

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=548694





--- Comment #7 from Jan Hutař <jhutar at redhat.com>  2010-01-07 03:27:25 EDT ---
(In reply to comment #4)

> # MUST: The sources used to build the package must match the upstream source,
> # as provided in the spec URL. Reviewers should use md5sum for this task. If no
> # upstream URL can be specified for this package, please see the Source URL
> # Guidelines for how to deal with this.
> NOT OK
> 
>     $ curl https://fedorahosted.org/releases/r/p/rpmfluff/rpmfluff-0.3.tar.bz2
> | md5sum
>     b349770877d43d9fd71d53ece24a4165
> 
>     $ rpm -ivh
> https://fedorahosted.org/releases/r/p/rpmfluff/python-rpmfluff-0.3-1.fc10.src.rpm
>        1:python-rpmfluff     ########################################### [100%]
>     $ md5sum /tmp/jlaska-rpm/SOURCES/rpmfluff-0.3.tar.bz2
>     db40cf13beb5241835d9256a90e998be 
> /tmp/jlaska-rpm/SOURCES/rpmfluff-0.3.tar.bz2

Fixed now in 0.3-3:

$ curl https://fedorahosted.org/releases/r/p/rpmfluff/rpmfluff-0.3.tar.bz2 |
md5sum 
cd00673f122358f29a2635b96c46a5bd  -
$ rpm -ivh
https://fedorahosted.org/releases/r/p/rpmfluff/python-rpmfluff-0.3-3.fc12.src.rpm
   1:python-rpmfluff        ########################################### [100%]
$ md5sum rpmbuild/SOURCES/rpmfluff-0.3.tar.bz2
cd00673f122358f29a2635b96c46a5bd  rpmbuild/SOURCES/rpmfluff-0.3.tar.bz2

> # MUST: All build dependencies must be listed in BuildRequires, except for any
> # that are listed in the exceptions section of the Packaging Guidelines ;
> # inclusion of those as BuildRequires is optional. Apply common sense.
> OK
> 
> If you wish to change to using python distutils, you may wish to add
> BuildRequires: python-setuptools-devel

Added.


Thank you for review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.