[Bug 551878] Review Request: font-manager - A font management application for the GNOME desktop environment

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551878





--- Comment #11 from Jean-Francois Saucier <jfsaucier at infoglobe.ca>  2010-01-07 14:51:40 EDT ---
Spec URL: http://jfsaucier.fedorapeople.org/packages/font-manager.spec
SRPM URL:
http://jfsaucier.fedorapeople.org/packages/font-manager-0.4.2-5.fc12.src.rpm


> * License is "GPLv3+"

Fixed.


> * Why are the *.py source files not included

Fixed. I patched the upstream Makefile to correct this. The weird thing is that
static.py must not be included in the final package, so I cannot make the
*.py[co] regexp into *.py* in the Makefile. I found a good regexp for this
yesterday but it didn't work in Makefile :

install -m 644 !(static).py?(c|o) $(DESTDIR)$(prefix)/share/font-manager/

It work fine in a shell but the Makefile didn't like the parenthesis. I have
talked about this in #fedora-devel and not found a solution. For the moment, I
resign myself to include the name of all the files I want packaged.


> and possibly take the chance to compile with -O1 instead of -O0.

Maybe there is something I don't understand here (I am kind of new to python)
but in the Makefile, I have :

@python -OO -m compileall .

So, it seems to compile with -O2 if I understand correctly. Am I wrong here?


> * The "tmpdir" code in /usr/share/font-manager/export.py* is reason to worry.

Like I said before, I am kind of new in python, so I will try to look at this
issue in collaboration with upstream. I will come back as soon as I have
something on this.


Thank you!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.