[Bug 532276] Review Request: python-googlevoice - Python language bindings for the Google Voice API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=532276


Rakesh Pandit <rpandit at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rpandit at redhat.com
               Flag|                            |fedora-review?




--- Comment #3 from Rakesh Pandit <rpandit at redhat.com>  2010-01-08 05:42:55 EDT ---
[x] - Ok, [-] Needs input, [na] - Not Applicable
[-] Update to latest

That will include rename docs to doc and including:
   /usr/bin/asterisk-gvoice-setup
   /usr/bin/gvi

in %files section

[x] name fine
[x] spec file name fine
[x] egg files are getting generated
[x] python-setuptools-devel included
[x] rpmlint is happy
[x] docs and examples are included
[-] license fine, but neither source nor license copy present. May you tell
upstream to mention about it some place in source tarball also and if possible
in source files. BSD is okay.
[x] byte compiled files included
[x] source ok
835f3631192fa586341ac3da8b847812d5fd4cf1  pygooglevoice-0.4.tar.gz
4a1f19313812d4cc078e39ac9f40e9b4ab8ed432  pygooglevoice-0.4-extras.zip
sha1sum matches
[x] spec fields fine
[x] %files section and permissions fine
[x] American english and spec legible
[x] File names in package valid UTF-8
[x] permissions file

Summary:

May you inform upstream about license bits and update the package to latest.
Everything else seems to be fine.

Thanks,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.