[Bug 553402] Review Request: remmina - A GTK+ Remote Desktop Client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=553402


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |lkundrak at v3.sk
         AssignedTo|nobody at fedoraproject.org    |lkundrak at v3.sk
               Flag|                            |fedora-review?




--- Comment #3 from Lubomir Rintel <lkundrak at v3.sk>  2010-01-08 09:50:12 EDT ---
* Named correctly
* Version correct
* Source matches upstream
* Spec file clean, legible, American english
* RPMlint silent
* Builds in mock
* Filelist sane
* Requires/provides sane
* Scritplets fine
* Uses compiler flags correctly

Needs work:

1.) License

  3des.* files lack licensing information
    (you may want to find other software that includes this to clarify
licensing,
    or use an existing library for tripple DES encryption)
  zywrletemplate.c
    This looks like a BSD license, not GPL
  keysym.h
    MIT license?

2.) Embedded copies of libraries

Please look into possibility of using existing vnc library present in Fedora
instead of libvncserver.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.