[Bug 551838] Review Request: opendchub - A hub software for Direct Connect

bugzilla at redhat.com bugzilla at redhat.com
Fri Jan 8 18:22:12 UTC 2010


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=551838





--- Comment #9 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2010-01-08 13:22:11 EDT ---
For -4:

* BR
  - Now this srpm calls autotools, "BR: automake" is needed
  ! Note
    After adding "BR: automake", build.log shows:
--------------------------------------------------------
   145  + make -j4
   146  (CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/sh
/builddir/build/BUILD/opendchub-0.8.1/missing --run autoheader)
   147  autoheader: WARNING: Using auxiliary files such as `acconfig.h',
`config.h.bot'
--------------------------------------------------------
    It is not preferable that autotools are automatically called
    after configure. So "$ autoheader" should also be called
    before configure.

! Miscs
  - Would you divide a long line (for example with containing more
    than 80 characters) into two lines?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list